xiaoxiang781216 commented on code in PR #17065:
URL: https://github.com/apache/nuttx/pull/17065#discussion_r2374698101


##########
arch/tricore/src/common/tricore_systimer.c:
##########
@@ -376,7 +443,13 @@ tricore_systimer_initialize(volatile void *tbase, int irq, 
uint64_t freq)
   IfxStm_enableComparatorInterrupt(tbase, IfxStm_Comparator_0);
 
   irq_attach(irq, tricore_systimer_interrupt, priv);
-  up_enable_irq(irq);
 
-  return (struct oneshot_lowerhalf_s *)priv;
+  up_alarm_set_lowerhalf((struct oneshot_lowerhalf_s *)priv);

Review Comment:
   but this code can't handle the tickless mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to