trns1997 commented on code in PR #17017:
URL: https://github.com/apache/nuttx/pull/17017#discussion_r2379306479
##########
.github/workflows/build.yml:
##########
@@ -201,6 +201,51 @@ jobs:
path: buildartifacts/
continue-on-error: true
+ # Test the out-of-tree build
+ OOT-Build:
+ needs: Linux
+ runs-on: ubuntu-latest
+ env:
+ DOCKER_BUILDKIT: 1
+ steps:
+ - name: Download Source Artifact
+ uses: actions/download-artifact@v5
+ with:
+ name: source-bundle
+ path: .
+
+ - name: Extract sources
+ run: tar zxf sources.tar.gz
+
+ - name: Docker Login
+ uses: docker/login-action@v3
+ with:
+ registry: ghcr.io
+ username: ${{ github.actor }}
+ password: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Export NuttX Repo SHA
+ run: echo "nuttx_sha=`git -C sources/nuttx rev-parse HEAD`" >>
$GITHUB_ENV
+
+ - name: Run Out-of-Tree Build Test
+ uses: ./sources/nuttx/.github/actions/ci-container
+ env:
+ BLOBDIR: /tools/blobs
+ with:
+ run: |
+ echo "::add-matcher::sources/nuttx/.github/gcc.json"
+ git config --global --add safe.directory
/github/workspace/sources/nuttx
+ git config --global --add safe.directory
/github/workspace/sources/apps
+ cd sources/nuttx
+ ./tools/ci/cibuild-oot.sh
+
+ - uses: actions/upload-artifact@v4
+ if: ${{ always() }}
+ with:
+ name: oot-build-artifacts
+ path: sources/apps/testing/cxx-oot-build
Review Comment:
> @trns1997 Please, can you add tests done locally? The cibuild-oot.sh
script is missing the step where artifacts are stored.
>
> you can see in this script testbuild.sh
>
>
https://github.com/apache/nuttx/blob/d243322f5770f2611d60a428e1c5410139c9daab/tools/testbuild.sh#L28
>
>
https://github.com/apache/nuttx/blob/d243322f5770f2611d60a428e1c5410139c9daab/tools/testbuild.sh#L397
@simbit18, essentially the path is set to the `cxx-oot-build` app in the
nuttx-apps which has just been merged. Not sure i need to create a specific
artifact directory ? And as far as local test go i just followed the steps in
the docomentation section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
