linguini1 commented on code in PR #17071: URL: https://github.com/apache/nuttx/pull/17071#discussion_r2380032265
########## drivers/timers/CMakeLists.txt: ########## @@ -22,6 +22,13 @@ set(SRCS) +# Unless a driver with a more accurate version of up_*delay is enabled, always +# include the base delay definition (busy-loop) as a minimum-viable product. + +if(NOT CONFIG_TIMER_ARCH) Review Comment: After looking at this, I think it would need a separate PR and time to think. The `up_udelay` in the timer implementation is dependent on the timer driver lower-half. I'm not certain right now what the best way to replace that with `clock_systime_timespec` is, and it would require a lot more testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
