spiriou commented on pull request #362: URL: https://github.com/apache/incubator-nuttx-apps/pull/362#issuecomment-672980555
@patacongo @xiaoxiang781216 indeed most of the code+unit-tests is downloaded from https://github.com/libuv/libuv/. I added in the patch the apache license (with the libuv license below) to protect the modifications to support NuttX on those files. There are still few exceptions. Those files are issued from a copy/paste, and modified so they can work on NuttX. The modifications are too heavy to be managed with #ifdef #endif. What I did is reuse the libuv license, with apache license on top of it. Those files can be moved in the patch instead. system/libuv/libuv/nuttx_async.c system/libuv/libuv/nuttx_stream.c system/libuv/libuv/nuttx_threadpool.c system/libuv/libuv/nuttx.c system/libuv/libuv/nuttx_tcp.c system/libuv/libuv/nuttx_timer.c: that one is done from scratch so no license issue. It just implements the libuv API for that feature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
