szafonimateusz-mi commented on code in PR #17126: URL: https://github.com/apache/nuttx/pull/17126#discussion_r2390998788
########## fs/mmap/fs_mmap.c: ########## @@ -279,10 +279,9 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, FAR void *mapped = NULL; int ret; - if (fd != -1 && file_get(fd, &filep) < 0) + if (fd != -1 && (ret = file_get(fd, &filep)) < 0) Review Comment: -1 is correct here according to the standard. This is special case used for MAP_ANONYMOUS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
