xiaoxiang781216 commented on code in PR #17121:
URL: https://github.com/apache/nuttx/pull/17121#discussion_r2390053638
##########
Kconfig:
##########
@@ -2457,7 +2457,7 @@ config STACK_COLORATION
config STACKCHECK_SOFTWARE
bool "Software detection of stack overflow"
- depends on STACK_COLORATION && DEBUG_ASSERTIONS &&
SCHED_SUSPENDSCHEDULER
Review Comment:
this fix by: https://github.com/apache/nuttx/pull/17075/files
##########
Kconfig:
##########
@@ -2457,7 +2457,7 @@ config STACK_COLORATION
config STACKCHECK_SOFTWARE
bool "Software detection of stack overflow"
- depends on STACK_COLORATION && DEBUG_ASSERTIONS &&
SCHED_SUSPENDSCHEDULER
+ depends on STACK_COLORATION && DEBUG_ASSERTIONS
Review Comment:
```suggestion
depends on DEBUG_ASSERTIONS
```
##########
Kconfig:
##########
@@ -2467,8 +2467,8 @@ config STACKCHECK_SOFTWARE
config STACKCHECK_MARGIN
Review Comment:
let's use -1 mean disable, 0 check sp, > 0 check color, so we can merge
STACKCHECK_MARGIN and STACKCHECK_SOFTWARE into one option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
