raiden00pl commented on code in PR #17203:
URL: https://github.com/apache/nuttx/pull/17203#discussion_r2441794941
##########
arch/arm/src/stm32h7/stm32_dma.c:
##########
@@ -959,6 +970,20 @@ static void stm32_mdma_setup(DMA_HANDLE handle,
stm32_dmacfg_t *cfg)
#warning stm32_mdma_setup not implemented
}
+/****************************************************************************
+ *
+ * Description
Review Comment:
```suggestion
/****************************************************************************
* Name: stm32_mdma_free
*
*
* Description
```
##########
arch/arm/src/stm32h7/stm32_dma.c:
##########
@@ -959,6 +970,20 @@ static void stm32_mdma_setup(DMA_HANDLE handle,
stm32_dmacfg_t *cfg)
#warning stm32_mdma_setup not implemented
}
+/****************************************************************************
+ *
+ * Description
+ * Free master DMA
+ *
+ ****************************************************************************/
+
+static void stm32_mdma_free(DMA_HANDLE handle)
+{
+ DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
Review Comment:
```suggestion
DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
```
##########
arch/arm/src/stm32h7/stm32_dma.c:
##########
@@ -1393,6 +1418,21 @@ static void stm32_sdma_setup(DMA_HANDLE handle,
stm32_dmacfg_t *cfg)
dmachan_putreg(dmachan, STM32_DMA_SCR_OFFSET, regval);
}
+/****************************************************************************
+ * Name: stm32_sdma_sfree
+ *
+ * Description:
+ * Free master DMA
+ *
+ ****************************************************************************/
+
+static void stm32_sdma_free(DMA_HANDLE handle)
+{
+ DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
+
Review Comment:
```suggestion
DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
```
##########
arch/arm/src/stm32h7/stm32_dma.c:
##########
@@ -1961,6 +2001,21 @@ static void stm32_bdma_setup(DMA_HANDLE handle,
stm32_dmacfg_t *cfg)
dmachan_putreg(dmachan, STM32_BDMACH_CCR_OFFSET, regval);
}
+/****************************************************************************
+ * Name: stm32_bdma_sfree
+ *
+ * Description:
+ * Free master DMA
+ *
+ ****************************************************************************/
+
+static void stm32_bdma_free(DMA_HANDLE handle)
+{
+ DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
+
Review Comment:
```suggestion
DMA_CHANNEL dmachan = (DMA_CHANNEL)handle;
```
##########
arch/arm/src/stm32h7/stm32_dma.c:
##########
@@ -959,6 +970,20 @@ static void stm32_mdma_setup(DMA_HANDLE handle,
stm32_dmacfg_t *cfg)
#warning stm32_mdma_setup not implemented
}
+/****************************************************************************
+ *
+ * Description
Review Comment:
```suggestion
/****************************************************************************
* Name: stm32_mdma_free
*
* Description
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
