Fix-Point commented on PR #17214: URL: https://github.com/apache/nuttx/pull/17214#issuecomment-3425549777
> The testing section needs more detail. It is insufficient to just state what hardware you tested on, since we have no idea what you tested. > > I saw in one of your replies that you linked to this: https://github.com/Fix-Point/projOPENVELA-InvariantDivisor/blob/main/test_div.c; that's something that should be mentioned in your test section. Link to your test cases, provide logs from them if they generate logs, etc. > > What did you test on hardware, just these test cases? Do they avoid a regression in the `indiv_u32` function you optimized, and how did you test for that? These are all good things to include just to help us track down gaps in testing if we find any problems post-merge, and to make sure code that gets merged is properly tested. Thank you for suggestions. The test description is briefly supplemented. From the test results, the `invdiv` has better performance than the branchfree implementation of the `libdivide`, since it has lower latency per operation. <img width="998" height="522" alt="image" src="https://github.com/user-attachments/assets/a5c6673c-5263-4757-972a-2e4a7109e762"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
