sumpfralle commented on PR #17224: URL: https://github.com/apache/nuttx/pull/17224#issuecomment-3430145710
Thanks for your comments! > Just to wrap my head around this, did [d8cb775](https://github.com/apache/nuttx/commit/d8cb7759b657cf92dfb66aa8cf8c4ff6391a4d40) break the RP2040 code for SMP flash writing entirely? It was a compile-time breakage. The referenced function was simply missing. See #16203. No other file contained a reference to that function. Probably it is a rare use-case (for now) to write to the internal flash storage. > What I'm wondering is, do the up_cpu_pause/resume and etc. functions removed in the linked commit not achieve the same task that you'd achieve by creating your general SMP isolation functions? This is not really my area of expertise, but I guess, d8cb775 wanted to replace a dirty implementation (which was used in too many places) with a clean implementation. But that is just guessing. I cannot really understand that commit message, but this is probably based on my lack of understanding for NuttX's scheduling infrastructure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
