patacongo commented on pull request #1565: URL: https://github.com/apache/incubator-nuttx/pull/1565#issuecomment-674097975
> > @patacongo could you review the new change which keep wdparam_t as before. > > I just skimmed through the changes. This looks much better to me. Thank you. > > I will wait until all checks pass before doing a file review. > > > It's better to merge [apache/incubator-nuttx-apps#361](https://github.com/apache/incubator-nuttx-apps/pull/361) first, and then rerun this PR again if no more issue is found. > > Okay, will do. Well, I see no reason to merge pache/incubator-nuttx-apps#361 first. That is guaranteed be break the build. If I merge both at once, there is a chance that the build will survive. I think that is the best route to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
