xiaoxiang781216 commented on code in PR #17223:
URL: https://github.com/apache/nuttx/pull/17223#discussion_r2454996607
##########
include/nuttx/event.h:
##########
@@ -73,7 +73,6 @@ struct nxevent_s
{
struct list_node list; /* Waiting list of nxevent_wait_t */
volatile nxevent_mask_t events; /* Pending Events */
- spinlock_t lock; /* Spinlock */
Review Comment:
but spinlock could avoid the global big lock, why do we switch back?
##########
include/nuttx/event.h:
##########
@@ -66,7 +67,7 @@ struct nxevent_wait_s
struct list_node node; /* Wait node of current task */
nxevent_mask_t expect; /* Expect events of wait task */
nxevent_flags_t eflags; /* Event flags of wait task */
- sem_t sem; /* Wait sem of current task */
Review Comment:
remove line 33
##########
include/nuttx/sched.h:
##########
@@ -253,6 +253,7 @@ enum tstate_e
TSTATE_TASK_INACTIVE, /* BLOCKED - Initialized but not yet
activated */
TSTATE_WAIT_SEM, /* BLOCKED - Waiting for a semaphore */
TSTATE_WAIT_SIG, /* BLOCKED - Waiting for a signal */
+ TSTATE_WAIT_EVENT, /* BLOCKED - Waiting for a event */
Review Comment:
why not continue use TSTATE_WAIT_SIG with alias
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
