cederom commented on code in PR #17216: URL: https://github.com/apache/nuttx/pull/17216#discussion_r2467773544
########## boards/arm64/qemu/qemu-armv8a/configs/fastboot/defconfig: ########## @@ -31,17 +31,19 @@ CONFIG_DRIVERS_VIRTIO_NET=y CONFIG_DRIVERS_VIRTIO_RNG=y CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_DRIVERS_VIRTIO_SOUND=y +CONFIG_ETC_ROMFS=y CONFIG_EXAMPLES_HELLO=y CONFIG_FAT_LCNAMES=y CONFIG_FAT_LFN=y CONFIG_FS_FAT=y CONFIG_FS_FATTIME=y CONFIG_FS_PROCFS=y +CONFIG_FS_ROMFS=y CONFIG_FS_V9FS=y CONFIG_HAVE_CXX=y CONFIG_HAVE_CXXINITIALIZE=y CONFIG_IDLETHREAD_STACKSIZE=8192 -CONFIG_INIT_ENTRYPOINT="nsh_main" +CONFIG_INIT_ENTRYPOINT="init_main" Review Comment: hmm, okay, so depending on the init type chosen all of them will provide `init_main` and this provides single kconfig configuration string for all of them i see it now thanks :-) there should be no conflicts because only one can be selected at time. my concern was that we will not know what init type is used right from the symbols table and additional source of information would be necessary i.e. configuration. your approach seems more versatile thanks :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
