TangMeng12 commented on PR #17236: URL: https://github.com/apache/nuttx/pull/17236#issuecomment-3455504187
> @TangMeng12 , allow me to make a few observations. > > As already mentioned #13301, the current system was designed to speed up and reduce errors during the cloning/download step (also possible with Curl downloads if desired) on our CI. > > This system on CI makes sense when the packages need to be used in multiple configurations (currently only for Arch Expressif ) > > jobs Linux (risc-v-04), Linux (xtensa-01), Linux (xtensa-02) > > With this simple check > > `ifneq ($(wildcard $(NXTMPDIR)/.*),)` > > We can insert any package (if necessary) from the Nuttx or Apps repository into the storage directory. > > Storage is enabled with > > -S adds the nxtmpdir folder for third-party packages. > > in the build.yml workflow on GitHub > > https://github.com/apache/nuttx/blob/201406b22b8035763fe81752aad71a1fba394ee8/.github/workflows/build.yml#L194 > > and if desired, you can use it locally example > > `./tools/configure.sh -l -S esp32-devkitc:nsh` > > https://github.com/apache/nuttx/blob/201406b22b8035763fe81752aad71a1fba394ee8/tools/configure.sh#L35 > > At the moment, simply using CONFIG_ALLOW_DOWNLOADS (must be added to all Expressif configurations!) does not meet the requirements of our CI! > > @TangMeng12 Converted back to draft to avoid accidental merging. > > The impact must be considered !!! In my updated commit, `CONFIG_ALLOW_DOWNLOADS` is set to 'y' by default, which does not affect any current logic under default settings. When the developer needs to use local code, can set `CONFIG_ALLOW_DOWNLOADS is not set`, in which case it will no longer download automatically, and the developer will need to provide the required code. Since this does not affect the existing logic, I have made some changes in this PR first. Because we also want to set up an internal CI environment, we hope not to download external code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
