wangchdo commented on PR #17244: URL: https://github.com/apache/nuttx/pull/17244#issuecomment-3466108025
> > > > > you need fix apps/nshlib/, procfs/ and tools/pynuttx/nxgdb/ too. > > > > > > > > > > > > Hi @xiaoxiang781216 Do you think this PR can be merged after `apps/nshlib/, procfs/ and tools/pynuttx/nxgdb/` are fixed? > > > > > > > > > apps/nshlib could, but other need be part of this pr. > > > > > > Hi @xiaoxiang781216 > > I’ve uploaded a fix for tools/pynuttx/nxgdb and sched_get_stateinfo.c/g_statenames. Could you please help review it? > > Also, I didn’t find anything in procfs/ that needs to be updated. I believe the new state doesn’t affect procfs/, but could you please help double-check that? > > The latest code call nxsched_get_stateinfo to convert enum to string in all place, and your patch already update nxsched_get_stateinfo, so the problem is fixed. > > > Besides, I think no changes are needed in apps/nshlib/ either — as long as sched_get_stateinfo.c/g_statenames is updated, everything should work correctly. Please check the test code and ps output below for confirmation. > > you are right. @xiaoxiang781216 Thank you very much! Could you please check if this PR is ready to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
