wangchdo commented on code in PR #17324:
URL: https://github.com/apache/nuttx/pull/17324#discussion_r2522890008
##########
sched/sched/sched_suspend.c:
##########
@@ -170,13 +170,12 @@ void nxsched_suspend(FAR struct tcb_s *tcb)
{
switch_needed = nxsched_remove_readytorun(tcb);
- if (switch_needed || !nxsched_islocked_tcb(rtcb))
+ if (switch_needed)
{
#ifdef CONFIG_SMP
- switch_needed |= nxsched_deliver_task(cpu, tcb->cpu,
- SWITCH_HIGHER);
+ nxsched_deliver_task(cpu, tcb->cpu, SWITCH_HIGHER);
#else
- switch_needed |= nxsched_merge_pending();
+ nxsched_merge_pending();
#endif
Review Comment:
Maybe you miss my word:
The current running task is always the highest priority if it does not lock
sched, and if it locked sched we certainly donot need to check other tasks
We do not need to check other tasks here because if the sched is not locked
the current task is highest priority, if sched is locked why do we need the
check?
the check doesn't change anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
