wangchdo commented on code in PR #17327: URL: https://github.com/apache/nuttx/pull/17327#discussion_r2523137458
########## arch/tricore/src/tc397/chip.h: ########## @@ -27,4 +27,7 @@ * Included Files ****************************************************************************/ +#define UART_PIN_RX IfxAsclin0_RXA_P14_1_IN /* UART receive port pin */ Review Comment: Let's remove the duplicated definition in tc3xx_serial.c ########## arch/tricore/src/tc397/chip.h: ########## @@ -27,4 +27,7 @@ * Included Files ****************************************************************************/ +#define UART_PIN_RX IfxAsclin0_RXA_P14_1_IN /* UART receive port pin */ Review Comment: You should remove unrelated commit log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
