xiaoxiang781216 commented on code in PR #17316: URL: https://github.com/apache/nuttx/pull/17316#discussion_r2525917197
########## include/nuttx/timers/clkcnt.h: ########## @@ -0,0 +1,451 @@ +/**************************************************************************** + * include/nuttx/timers/clkcnt.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_TIMERS_CLKCNT_H +#define __INCLUDE_NUTTX_TIMERS_CLKCNT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <assert.h> +#include <stdint.h> + +#include <nuttx/clock.h> +#include <nuttx/compiler.h> +#include <nuttx/lib/math32.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define CLKCNT_MAX UINT64_MAX + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +typedef uint64_t clkcnt_t; Review Comment: BTW, there is a dissussion to remove 32bit time_t support(https://github.com/apache/nuttx/pull/14460) to confirm POSIX requirement. Actually, I would suggest that all commercial projects should always enable 64bit time_t, otherwise the overflow issue will bite you suddenly sooner or later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
