(nuttx) branch master updated: tools/checkpatch.sh: Improved error display on GitHub

[acassis]

This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 6161fececfb tools/checkpatch.sh: Improved error display on GitHub
6161fececfb is described below

commit 6161fececfb2e510cd947131634d8fa352657886
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
AuthorDate: Fri Nov 14 14:52:31 2025 +0100

    tools/checkpatch.sh: Improved error display on GitHub
    
    The improvement includes symbols that help employees visualise any errors 
detected during the PR check phase (check.yml).
    
    Error -> ❌ U+274C  Cross Mark
                 https://en.wikipedia.org/wiki/X_mark
    
    Checks pass -> ✔️ U+2714 Heavy Check Mark
                 https://en.wikipedia.org/wiki/Check_mark
    
    These characters are emojis that are recognized by the Unicode standards 
which define what each character represents.
    
    Signed-off-by: simbit18 <simbi...@gmail.com>
---
 tools/checkpatch.sh | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/tools/checkpatch.sh b/tools/checkpatch.sh
index 57f35c7ca97..cce2e6f2d29 100755
--- a/tools/checkpatch.sh
+++ b/tools/checkpatch.sh
@@ -297,17 +297,17 @@ check_msg() {
 
   while IFS= read -r REPLY; do
     if [[ $REPLY =~  ^Change-Id ]]; then
-      echo "Remove Gerrit Change-ID's before submitting upstream"
+      echo "❌ Remove Gerrit Change-ID's before submitting upstream"
       fail=1
     fi
 
     if [[ $REPLY =~  ^VELAPLATO ]]; then
-      echo "Remove VELAPLATO before submitting upstream"
+      echo "❌ Remove VELAPLATO before submitting upstream"
       fail=1
     fi
 
     if [[ $REPLY =~  ^[Ww][Ii][Pp]: ]]; then
-      echo "Remove WIP before submitting upstream"
+      echo "❌ Remove WIP before submitting upstream"
       fail=1
     fi
 
@@ -319,22 +319,22 @@ check_msg() {
   done <<< "$msg"
 
   if ! [[ $first =~  : ]]; then
-    echo "Commit subject missing colon (e.g. 'subsystem: msg')"
+    echo "❌ Commit subject missing colon (e.g. 'subsystem: msg')"
     fail=1
   fi
 
   if (( ${#first} > $max_line_len )); then
-    echo "Commit subject too long > $max_line_len"
+    echo "❌ Commit subject too long > $max_line_len"
     fail=1
   fi
 
   if ! [ $signedoffby_found == 1 ]; then
-    echo "Missing Signed-off-by"
+    echo "❌ Missing Signed-off-by"
     fail=1
   fi
 
   if (( $num_lines < $min_num_lines && $signedoffby_found == 1 )); then
-    echo "Missing git commit message"
+    echo "❌ Missing git commit message"
     fail=1
   fi
 }
@@ -409,12 +409,11 @@ for arg in $@; do
   $check $arg
 done
 
-
 if [ $fail == 1 ]; then
     echo "Some checks failed. For contributing guidelines, see:"
     echo "  $COMMIT_URL"
 else
-    echo "All checks pass."
+    echo "✔️ All checks pass."
 fi
 
 exit $fail