wangchdo commented on code in PR #17359:
URL: https://github.com/apache/nuttx/pull/17359#discussion_r2551429657
##########
fs/vfs/fs_signalfd.c:
##########
@@ -149,7 +149,7 @@ static int signalfd_file_close(FAR struct file *filep)
for (signo = MIN_SIGNO; signo <= MAX_SIGNO; signo++)
{
- if (nxsig_ismember(&dev->sigmask, signo))
+ if (nxsig_ismember(&dev->sigmask, signo) == 1)
Review Comment:
I think about this again, and I think check ==1 is more robust, because this
function may return value -EINVAL if the para is invalid, if we keep the
previous implementation, this will be treated as success in the condition
check, this is incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
