xiaoxiang781216 commented on code in PR #17352: URL: https://github.com/apache/nuttx/pull/17352#discussion_r2554717463
########## include/nuttx/signal.h: ########## @@ -696,6 +698,28 @@ void nxsig_cancel_notification(FAR struct sigwork_s *work); # define nxsig_cancel_notification(work) #endif +#else + +# define nxsig_ismember(set,sig) -EINVAL +# define nxsig_addset(set,sig) -EINVAL Review Comment: Please remove all dummy function which always report error, since we need change the runtime error to compile error and then remove the broken function directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
