jlaitine commented on code in PR #2954:
URL: https://github.com/apache/nuttx-apps/pull/2954#discussion_r2559709951
##########
nshlib/nsh_fscmds.c:
##########
@@ -2234,8 +2233,7 @@ int cmd_rm(FAR struct nsh_vtbl_s *vtbl, int argc, FAR
char **argv)
{
if (recursive)
{
- strlcpy(buf, fullpath, PATH_MAX);
Review Comment:
Perhaps do what @xiaoxiang781216 proposed, instead of allocating the buffer
from the stack, we could use lib_get_pathbuffer to keep stack usage smaller. I
can make a patch for this if so wanted...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
