xiaoxiang781216 commented on code in PR #3219:
URL: https://github.com/apache/nuttx-apps/pull/3219#discussion_r2560398744
##########
testing/testsuites/kernel/syscall/cmocka_syscall_test.c:
##########
@@ -161,6 +161,7 @@ int main(int argc, char *argv[])
test_nuttx_syscall_getpeername01,
test_nuttx_syscall_test_group_setup,
test_nuttx_syscall_test_group_teardown),
+# ifdef CONFIG_NET_IPv4
Review Comment:
should we check NET_SOCKOPTS
##########
examples/fb/fb_main.c:
##########
@@ -207,6 +208,17 @@ static int fb_init_mem2(FAR struct fb_state_s *state)
return EXIT_FAILURE;
}
+ fbmem = mmap(NULL, pinfo.fblen, PROT_READ | PROT_WRITE,
+ MAP_SHARED | MAP_FILE, state->fd, 0);
+
+ if (fbmem == MAP_FAILED)
+ {
+ int errcode = errno;
+ fprintf(stderr, "ERROR: ioctl(FBIOGET_PLANEINFO) failed: %d\n",
+ errcode);
Review Comment:
align
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
