linguini1 commented on PR #17372: URL: https://github.com/apache/nuttx/pull/17372#issuecomment-3587701933
> > @lipengfei28 all of your recent PRs are entirely missing proper descriptions according to the contribution guidelines. Please re-review them here: https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md > > done Did you read the guidelines? Once again, there is still text from the template remaining in your PR. You have included the command you used to invoke QEMU but no actual test logs. How are you specifically testing this change? It's not sufficient to say that "NuttX starts up normally". On top of this, I don't understand your description. What are BlockDescriptors? What problem is this solving? I guess something to do with being able to use the full pci mmio address space, but that is not really clear from this PR. Please use full detail when describing your change and why it is necessary. The impact in this case should include "affects all arm64 devices" since you are touching MMU logic for the arm64 architecture. Particularly in the case when `CONFIG_ARM64_PA_BITS=52`, but it also modifies common logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
