anchao commented on code in PR #17451: URL: https://github.com/apache/nuttx/pull/17451#discussion_r2598579967
########## drivers/usbdev/rndis.c: ########## @@ -2700,13 +2681,13 @@ static void usbclass_disconnect(FAR struct usbdevclass_driver_s *driver, priv->netdev.d_ifdown(&priv->netdev); - flags = enter_critical_section(); + while (nxmutex_lock(&priv->lock) < 0); Review Comment: Replace mutex will degrade performance on AMP mode, and some APIs cannot achieve ISR safety. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
