xiaoxiang781216 commented on PR #17493: URL: https://github.com/apache/nuttx/pull/17493#issuecomment-3648919039
> @jerenkrantz I think you found a BUG in boards/boardctl.c since up_flush_dcache_all() is not implemented for all architectures. > > @XuNeo could you please take a look? Since you added it here: #13908 > > I don't know what is the proper solution, maybe up_flush_dcache_all() could be defined as weak and only called if it exist. > > @xiaoxiang781216 @anchao @raiden00pl please take a look but it's strange why the linker error happen if the board doesn't enable CONFIG_ARCH_DCACHE since the dummy macro is provided in this case: https://github.com/apache/nuttx/blob/master/include/nuttx/cache.h#L447-L451 ``` /**************************************************************************** * Name: up_flush_dcache_all * * Description: * Flush the entire data cache by cleaning and invalidating the D cache. * * Input Parameters: * None * * Returned Value: * None * ****************************************************************************/ #ifdef CONFIG_ARCH_DCACHE void up_flush_dcache_all(void); #else # define up_flush_dcache_all() #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
