xiaoxiang781216 commented on code in PR #17486: URL: https://github.com/apache/nuttx/pull/17486#discussion_r2616181067
########## arch/z80/src/z80/Toolchain.defs: ########## @@ -121,5 +121,9 @@ LDMODULEFLAGS = -r -T $(call CONVERT_PATH,$(TOPDIR)/libs/libc/elf/gnu-elf.ld) CELFFLAGS = $(CFLAGS) -fvisibility=hidden CXXELFFLAGS = $(CXXFLAGS) -fvisibility=hidden -LDELFFLAGS = -r -e __start +ifeq ($(CONFIG_BINFMT_ELF_RELOCATABLE),y) + LDELFFLAGS = -r +else + LDELFFLAGS = -e _start Review Comment: but CONFIG_BINFMT_ELF_RELOCATABLE still need the entry point to work correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
