xiaoxiang781216 commented on code in PR #17489: URL: https://github.com/apache/nuttx/pull/17489#discussion_r2620747211
########## sched/hrtimer/hrtimer.h: ########## @@ -0,0 +1,172 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __SCHED_HRTIMER_HRTIMER_H +#define __SCHED_HRTIMER_HRTIMER_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <nuttx/hrtimer.h> + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +/* Red-Black tree containing all active high-resolution timers */ + +extern struct hrtimer_tree_s g_activetree; + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* Red-black tree head for managing active hrtimers */ + +RB_HEAD(hrtimer_tree_s, hrtimer_node_s); + +/**************************************************************************** + * Public Function Prototypes + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_process + * + * Description: + * Called from the timer interrupt handler to process expired + * high-resolution timers. If a timer has expired, its callback + * function will be executed in the context of the timer interrupt. + * + * Input Parameters: + * now - The current time (nsecs). + * + * Returned Value: + * None + ****************************************************************************/ + +void hrtimer_process(uint64_t now); + +/**************************************************************************** + * Inline Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_gettime + * + * Description: + * Get the current high-resolution time in nanoseconds. + * + * Returned Value: + * Current time in nanoseconds. + ****************************************************************************/ + +static inline_function +uint64_t hrtimer_gettime(void) Review Comment: move to hrtimer_start.c ########## sched/hrtimer/hrtimer_process.c: ########## @@ -0,0 +1,121 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer_process.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <assert.h> +#include <hrtimer/hrtimer.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_process + * + * Description: + * Process all expired high-resolution timers. This function repeatedly + * retrieves the earliest timer from the active timer RB-tree, checks if it + * has expired relative to the current time, removes it from the tree, + * and invokes its callback function. Processing continues until: + * + * 1. No additional timers have expired, or + * 2. The active timer set is empty. + * + * After all expired timers are processed, the next expiration event is + * scheduled based on: + * + * - The earliest remaining timer, or + * - A fallback expiration (current time + HRTIMER_DEFAULT_INCREMENT) + * if no timers remain. + * + * Input Parameters: + * ts - Pointer to the current high-resolution timestamp. + * + * Returned Value: + * None. + * + * Assumptions/Notes: + * - This function acquires a spinlock to protect the timer RB-tree. + * - Timer callbacks are invoked with interrupts enabled + * to avoid deadlocks. + * - DEBUGASSERT ensures that timer callbacks are valid. + ****************************************************************************/ + +void hrtimer_process(uint64_t now) Review Comment: call hrtimer_process in nxsched_process_timer ########## sched/hrtimer/hrtimer.h: ########## @@ -0,0 +1,172 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __SCHED_HRTIMER_HRTIMER_H +#define __SCHED_HRTIMER_HRTIMER_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <nuttx/hrtimer.h> + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +/* Red-Black tree containing all active high-resolution timers */ + +extern struct hrtimer_tree_s g_activetree; + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* Red-black tree head for managing active hrtimers */ + +RB_HEAD(hrtimer_tree_s, hrtimer_node_s); + +/**************************************************************************** + * Public Function Prototypes + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_process + * + * Description: + * Called from the timer interrupt handler to process expired + * high-resolution timers. If a timer has expired, its callback + * function will be executed in the context of the timer interrupt. + * + * Input Parameters: + * now - The current time (nsecs). + * + * Returned Value: + * None + ****************************************************************************/ + +void hrtimer_process(uint64_t now); Review Comment: let's call hrtimer_process in nxsched_process_timer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
