This is an automated email from the ASF dual-hosted git repository.
linguini pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d14a5c8b304 boards/leds: remove dependency on leds example for some
boards
d14a5c8b304 is described below
commit d14a5c8b304212eb17565307b33c95cae34623ca
Author: raiden00pl <[email protected]>
AuthorDate: Sat Jun 7 14:35:58 2025 +0200
boards/leds: remove dependency on leds example for some boards
Userled register path shouldn't depend on LED example.
This dependency is broken, kernel code should not depend on apps code.
Signed-off-by: raiden00pl <[email protected]>
---
boards/arm/kinetis/freedom-k64f/src/k64_bringup.c | 8 +-------
boards/arm/kinetis/freedom-k66f/src/k66_bringup.c | 8 +-------
boards/arm/nrf52/arduino-nano-33ble-rev2/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/arduino-nano-33ble/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52-feather/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52832-dk/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52832-mdk/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52832-sparkfun/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52840-dk/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/nrf52840-dongle/src/nrf52_bringup.c | 2 +-
boards/arm/nrf52/xiao-nrf52840/src/nrf52_bringup.c | 2 +-
boards/arm/nrf53/nrf5340-audio-dk/src/nrf53_bringup.c | 2 +-
boards/arm/nrf53/nrf5340-dk/src/nrf53_bringup.c | 2 +-
boards/arm/nrf91/nrf9160-dk/src/nrf91_bringup.c | 2 +-
boards/arm/samv7/pic32czca70-curiosity/src/sam_board.h | 8 --------
boards/arm/samv7/pic32czca70-curiosity/src/sam_bringup.c | 2 +-
boards/arm/samv7/samv71-xult/src/sam_bringup.c | 2 +-
boards/arm/samv7/samv71-xult/src/samv71-xult.h | 8 --------
boards/arm/stm32/nucleo-f401re/src/stm32_bringup.c | 8 +-------
boards/arm/stm32/nucleo-f411re/src/stm32_bringup.c | 8 +-------
20 files changed, 18 insertions(+), 58 deletions(-)
diff --git a/boards/arm/kinetis/freedom-k64f/src/k64_bringup.c
b/boards/arm/kinetis/freedom-k64f/src/k64_bringup.c
index 9b050d49938..1fbd4e88769 100644
--- a/boards/arm/kinetis/freedom-k64f/src/k64_bringup.c
+++ b/boards/arm/kinetis/freedom-k64f/src/k64_bringup.c
@@ -42,12 +42,6 @@
# include <nuttx/leds/userled.h>
#endif
-#ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-#else
-# define LED_DRIVER_PATH "/dev/userleds"
-#endif
-
#include <nuttx/spi/spi_transfer.h>
#include "kinetis_spi.h"
@@ -77,7 +71,7 @@ int k64_bringup(void)
#ifdef HAVE_LEDS
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/kinetis/freedom-k66f/src/k66_bringup.c
b/boards/arm/kinetis/freedom-k66f/src/k66_bringup.c
index 59bee88c3e4..f0f1444e900 100644
--- a/boards/arm/kinetis/freedom-k66f/src/k66_bringup.c
+++ b/boards/arm/kinetis/freedom-k66f/src/k66_bringup.c
@@ -38,12 +38,6 @@
# include <nuttx/leds/userled.h>
#endif
-#ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-#else
-# define LED_DRIVER_PATH "/dev/userleds"
-#endif
-
#include <nuttx/spi/spi.h>
#ifdef CONFIG_INPUT_BUTTONS
@@ -77,7 +71,7 @@ int k66_bringup(void)
#ifdef HAVE_LEDS
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/arduino-nano-33ble-rev2/src/nrf52_bringup.c
b/boards/arm/nrf52/arduino-nano-33ble-rev2/src/nrf52_bringup.c
index 6a80d4be0d6..923e5232203 100644
--- a/boards/arm/nrf52/arduino-nano-33ble-rev2/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/arduino-nano-33ble-rev2/src/nrf52_bringup.c
@@ -117,7 +117,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/arduino-nano-33ble/src/nrf52_bringup.c
b/boards/arm/nrf52/arduino-nano-33ble/src/nrf52_bringup.c
index e0293bd3777..ea2ab133fb2 100644
--- a/boards/arm/nrf52/arduino-nano-33ble/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/arduino-nano-33ble/src/nrf52_bringup.c
@@ -117,7 +117,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/nrf52-feather/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52-feather/src/nrf52_bringup.c
index a74f7fd64d8..a7aa51fb4cf 100644
--- a/boards/arm/nrf52/nrf52-feather/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52-feather/src/nrf52_bringup.c
@@ -74,7 +74,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/nrf52832-dk/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52832-dk/src/nrf52_bringup.c
index c5dbc7a44a0..db27ebc417e 100644
--- a/boards/arm/nrf52/nrf52832-dk/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52832-dk/src/nrf52_bringup.c
@@ -113,7 +113,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/nrf52832-mdk/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52832-mdk/src/nrf52_bringup.c
index fa3da7ec8d3..2787b47d723 100644
--- a/boards/arm/nrf52/nrf52832-mdk/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52832-mdk/src/nrf52_bringup.c
@@ -84,7 +84,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/nrf52832-sparkfun/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52832-sparkfun/src/nrf52_bringup.c
index 11ab95615a9..ee4daf0ad85 100644
--- a/boards/arm/nrf52/nrf52832-sparkfun/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52832-sparkfun/src/nrf52_bringup.c
@@ -72,7 +72,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/nrf52840-dk/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52840-dk/src/nrf52_bringup.c
index faaa0104725..25faf003e1e 100644
--- a/boards/arm/nrf52/nrf52840-dk/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52840-dk/src/nrf52_bringup.c
@@ -164,7 +164,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR,
diff --git a/boards/arm/nrf52/nrf52840-dongle/src/nrf52_bringup.c
b/boards/arm/nrf52/nrf52840-dongle/src/nrf52_bringup.c
index 79c973864b6..10fe2872e42 100644
--- a/boards/arm/nrf52/nrf52840-dongle/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/nrf52840-dongle/src/nrf52_bringup.c
@@ -73,7 +73,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf52/xiao-nrf52840/src/nrf52_bringup.c
b/boards/arm/nrf52/xiao-nrf52840/src/nrf52_bringup.c
index d38842028d9..74a78640e6a 100644
--- a/boards/arm/nrf52/xiao-nrf52840/src/nrf52_bringup.c
+++ b/boards/arm/nrf52/xiao-nrf52840/src/nrf52_bringup.c
@@ -75,7 +75,7 @@ int nrf52_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf53/nrf5340-audio-dk/src/nrf53_bringup.c
b/boards/arm/nrf53/nrf5340-audio-dk/src/nrf53_bringup.c
index c6f4af8e3ae..966b91f4ebb 100644
--- a/boards/arm/nrf53/nrf5340-audio-dk/src/nrf53_bringup.c
+++ b/boards/arm/nrf53/nrf5340-audio-dk/src/nrf53_bringup.c
@@ -58,7 +58,7 @@ int nrf53_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf53/nrf5340-dk/src/nrf53_bringup.c
b/boards/arm/nrf53/nrf5340-dk/src/nrf53_bringup.c
index f2cc3305cf5..e21543f54f3 100644
--- a/boards/arm/nrf53/nrf5340-dk/src/nrf53_bringup.c
+++ b/boards/arm/nrf53/nrf5340-dk/src/nrf53_bringup.c
@@ -196,7 +196,7 @@ int nrf53_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/nrf91/nrf9160-dk/src/nrf91_bringup.c
b/boards/arm/nrf91/nrf9160-dk/src/nrf91_bringup.c
index 2e7c03829cf..a5b4b971827 100644
--- a/boards/arm/nrf91/nrf9160-dk/src/nrf91_bringup.c
+++ b/boards/arm/nrf91/nrf9160-dk/src/nrf91_bringup.c
@@ -109,7 +109,7 @@ int nrf91_bringup(void)
#ifdef CONFIG_USERLED
/* Register the LED driver */
- ret = userled_lower_initialize(CONFIG_EXAMPLES_LEDS_DEVPATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/samv7/pic32czca70-curiosity/src/sam_board.h
b/boards/arm/samv7/pic32czca70-curiosity/src/sam_board.h
index 36bf2aeb5d0..385bfc7c166 100644
--- a/boards/arm/samv7/pic32czca70-curiosity/src/sam_board.h
+++ b/boards/arm/samv7/pic32czca70-curiosity/src/sam_board.h
@@ -138,14 +138,6 @@
# undef HAVE_LED_DRIVER
#endif
-#ifdef HAVE_LED_DRIVER
-# ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-# else
-# define LED_DRIVER_PATH "/dev/userleds"
-# endif
-#endif
-
/* Configuration ************************************************************/
/* PIC32CZ CA70 GPIO Pin Definitions ****************************************/
diff --git a/boards/arm/samv7/pic32czca70-curiosity/src/sam_bringup.c
b/boards/arm/samv7/pic32czca70-curiosity/src/sam_bringup.c
index 74924ea71c4..d6e0de0b226 100644
--- a/boards/arm/samv7/pic32czca70-curiosity/src/sam_bringup.c
+++ b/boards/arm/samv7/pic32czca70-curiosity/src/sam_bringup.c
@@ -125,7 +125,7 @@ int sam_bringup(void)
#ifdef HAVE_LED_DRIVER
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n",
diff --git a/boards/arm/samv7/samv71-xult/src/sam_bringup.c
b/boards/arm/samv7/samv71-xult/src/sam_bringup.c
index 68f5a6f6474..fc9a31929df 100644
--- a/boards/arm/samv7/samv71-xult/src/sam_bringup.c
+++ b/boards/arm/samv7/samv71-xult/src/sam_bringup.c
@@ -233,7 +233,7 @@ int sam_bringup(void)
#ifdef HAVE_LED_DRIVER
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n",
diff --git a/boards/arm/samv7/samv71-xult/src/samv71-xult.h
b/boards/arm/samv7/samv71-xult/src/samv71-xult.h
index e806afbb1a8..0d88cd08504 100644
--- a/boards/arm/samv7/samv71-xult/src/samv71-xult.h
+++ b/boards/arm/samv7/samv71-xult/src/samv71-xult.h
@@ -341,14 +341,6 @@
# undef HAVE_LED_DRIVER
#endif
-#ifdef HAVE_LED_DRIVER
-# ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-# else
-# define LED_DRIVER_PATH "/dev/userleds"
-# endif
-#endif
-
/* Check if the MRF24J40 is supported in this configuration */
#ifndef CONFIG_IEEE802154_MRF24J40
diff --git a/boards/arm/stm32/nucleo-f401re/src/stm32_bringup.c
b/boards/arm/stm32/nucleo-f401re/src/stm32_bringup.c
index b1daccc915b..75b7c40fb82 100644
--- a/boards/arm/stm32/nucleo-f401re/src/stm32_bringup.c
+++ b/boards/arm/stm32/nucleo-f401re/src/stm32_bringup.c
@@ -60,12 +60,6 @@
# define HAVE_LEDS 1
#endif
-#ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-#else
-# define LED_DRIVER_PATH "/dev/userleds"
-#endif
-
/****************************************************************************
* Public Functions
****************************************************************************/
@@ -91,7 +85,7 @@ int stm32_bringup(void)
#ifdef HAVE_LEDS
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);
diff --git a/boards/arm/stm32/nucleo-f411re/src/stm32_bringup.c
b/boards/arm/stm32/nucleo-f411re/src/stm32_bringup.c
index 22e899f0551..d89f203370f 100644
--- a/boards/arm/stm32/nucleo-f411re/src/stm32_bringup.c
+++ b/boards/arm/stm32/nucleo-f411re/src/stm32_bringup.c
@@ -60,12 +60,6 @@
# define HAVE_LEDS 1
#endif
-#ifdef CONFIG_EXAMPLES_LEDS_DEVPATH
-# define LED_DRIVER_PATH CONFIG_EXAMPLES_LEDS_DEVPATH
-#else
-# define LED_DRIVER_PATH "/dev/userleds"
-#endif
-
/****************************************************************************
* Public Functions
****************************************************************************/
@@ -91,7 +85,7 @@ int stm32_bringup(void)
#ifdef HAVE_LEDS
/* Register the LED driver */
- ret = userled_lower_initialize(LED_DRIVER_PATH);
+ ret = userled_lower_initialize("/dev/userleds");
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: userled_lower_initialize() failed: %d\n", ret);