wangchdo commented on PR #17573:
URL: https://github.com/apache/nuttx/pull/17573#issuecomment-3679810388
> Thank you @wangchdo amazing work and perfect reporting! :-)
>
>
>
> I have one issue, as there is a rename of very old and important file and
functions inside (`sched/sched/sched_processtimer.c →
sched/sched/sched_processtick.c`) this seems to be a breaking change, thus both
PR and related git commit topic should contain `!` as the first character, plus
description body should contain `BREAKING CHANGE: description on how API is
changed plus quick fix instructions`. Maybe such invasive change is not really
necessary? This will help existing users of that API to clearly notice a change
and adapt their code. Thanks! :-)
Hi @cederom
I think there is no breaking change here. I have put the original
sched_processtimer() function into the new added file nxschex_timer, and have
kept the function's prototype and function backwords compatible
The reason i do this is to add a concept of separating nxsxhed timer os
ticks: all the original implementation of sched_processtimer() is kept the same
in the new sched_processtick() to focus on process os ticks, and the new
sched_processtimer() acts as a wrapper of sched_processtick to handle the
difference of using hardware or a hrtimer instance to drive the os ticks
So if hrtimer is not enabled the new sched_processtimer is completely the
same as before by acting as a wrapper of sched_processtick, and if hrtimer is
enabled it will create an hrtimer instance to drive sched_processtick
So the key concept is that everything is not changed, just added the concept
of separating timer source choosing and os tick processing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
