Fix-Point commented on code in PR #17640:
URL: https://github.com/apache/nuttx/pull/17640#discussion_r2642567402
##########
sched/wdog/wd_cancel.c:
##########
@@ -61,34 +61,33 @@
int wd_cancel(FAR struct wdog_s *wdog)
{
irqstate_t flags;
- bool head;
+ bool reassess = false;
+ int ret = -EINVAL;
- flags = spin_lock_irqsave(&g_wdspinlock);
+ flags = enter_critical_section();
/* Make sure that the watchdog is valid and still active. */
- if (wdog == NULL || !WDOG_ISACTIVE(wdog))
+ if (wdog != NULL && WDOG_ISACTIVE(wdog))
Review Comment:
Thank you for the suggestion, it has been moved out to reduce size of the
critical section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
