xiaoxiang781216 commented on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678150846


   > > > It should work in theory.
   > > 
   > > 
   > > It's already in place for branches, @btashton set it up, we use it for 
releases.
   > > An extra effort is needed to make it work with PRs, I guess @btashton 
already has a draft somewhere.
   > 
   > Thanks @Ouss4! Good to know. Can we get it to pass CI?
   > 
   > I would like to test this in its entirety once it does pass.
   > 
   > @xiaoxiang781216 Give that the static allocation was not subject to 
fragmentation, would you explain the potential impact with this change to a 
long running system?
   
   If the system start/stop task frequently, the fragmentation may be a 
problem, but there is already many dynamic allocation to start a task:
   1.task_group_s
   2.task_tcb_s
   3.environ
   4.stack
   so the change don't degrade the situation too much. Also, if the 
fragementation is a problem, it's better to utilize a global file_struct pool 
instead per task since it's more memory efficient and scalable(simple task v.s. 
complex task).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to