xiaoxiang781216 commented on code in PR #3270:
URL: https://github.com/apache/nuttx-apps/pull/3270#discussion_r2646415310
##########
testing/cmocka/Kconfig:
##########
Review Comment:
```suggestion
bool "Enable libcmocka"
```
##########
testing/cmocka/Makefile:
##########
@@ -29,12 +29,14 @@ CFLAGS += -DHAVE_CLOCK_REALTIME=1
CFLAGS += -DHAVE_STRUCT_TIMESPEC=1
CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/testing/cmocka
+MODULE = $(CONFIG_TESTING_CMOCKA)
Review Comment:
```suggestion
MODULE = $(CONFIG_TESTING_CMOCKA_PROG)
```
##########
testing/cmocka/Kconfig:
##########
@@ -12,6 +12,15 @@ config TESTING_CMOCKA
if TESTING_CMOCKA
+config TESTING_CMOCKA_PROG
+ bool "Compile cmocka binary"
Review Comment:
```suggestion
tristate "Compile cmocka binary"
```
##########
testing/cmocka/Makefile:
##########
@@ -29,12 +29,14 @@ CFLAGS += -DHAVE_CLOCK_REALTIME=1
CFLAGS += -DHAVE_STRUCT_TIMESPEC=1
CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/testing/cmocka
+MODULE = $(CONFIG_TESTING_CMOCKA)
+
+ifeq ($(CONFIG_TESTING_CMOCKA_PROG),y)
Review Comment:
```suggestion
ifneq ($(CONFIG_TESTING_CMOCKA_PROG),)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
