wangchdo commented on code in PR #17675: URL: https://github.com/apache/nuttx/pull/17675#discussion_r2647649376
########## include/nuttx/hrtimer_queue_type.h: ########## @@ -0,0 +1,158 @@ +/**************************************************************************** + * include/nuttx/hrtimer_queue_type.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_HRTIMER_QUEUE_TYPE_H +#define __INCLUDE_HRTIMER_QUEUE_TYPE_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <nuttx/compiler.h> +#include <nuttx/clock.h> +#include <nuttx/seqlock.h> + +#include <nuttx/list.h> +#include <sys/tree.h> + +#include <stdint.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* The pending state indicates the timer belongs to the shared hrtimer queue + * and it can not be reclaimed until the timer is cancelled or completed. + */ + +#define HRTIMER_ISPENDING(timer) ((timer)->func != NULL) + +/* The maximum delay tick should be INT64_MAX. However, if there are expired + * hrtimer in the queue, HRTIMER_TIME_BEFORE/AFTER might be incorrect, so we + * limited the delay to INT64_MAX >> 1, assuming all expired hrtimer can be + * processed within HRTIMER_MAX_DELAY. + */ + +#define HRTIMER_MAX_DELAY (INT64_MAX >> 1) + +#define HRTIMER_TIME_BEFORE(t1, t2) ((int64_t)((t2) - (t1)) > 0) +#define HRTIMER_TIME_BEFORE_EQ(t1, t2) ((int64_t)((t2) - (t1)) >= 0) +#define HRTIMER_TIME_AFTER(t1, t2) ((int64_t)((t2) - (t1)) < 0) +#define HRTIMER_TIME_AFTER_EQ(t1, t2) ((int64_t)((t2) - (t1)) <= 0) + +#define HRTIMER_MODE_ABS (0) Review Comment: It is not safe to use a macro to represent the mode. We should use an enum instead, which allows the compiler to perform type checking for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
