wangchdo commented on PR #17675: URL: https://github.com/apache/nuttx/pull/17675#issuecomment-3692741619
@Fix-Point Let me make a conclusion of all my comments for your implementation into four categories: 1. Your way of resolving multicore running the same hrtimer for SMP system has performance issue and is not deterministic 2. You does not consider to remove un-needed operations when running on non-smp platform, so your implementation is also not good for non-smp platform 3. Your APIS are two complicated, not friendly for users 4. You do not decouple the queue abstraction for hrtimer very well, the queue related operations are not needed to be exposed to users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
