zhhyu7 commented on PR #17733: URL: https://github.com/apache/nuttx/pull/17733#issuecomment-3701527082
> @xiaoxiang781216 @zhhyu7 Alternatively, we can add a dedicated set of APIs for the new local locks while keeping the prototype of net_lock unchanged. > > extension `net/utils/net_lock.c` -> `net/utils/net_lock_ext.c` > > > > net_lock/net_unlock need keep the prototype without change since many net driver call net_lock/net_unlock and we don't have any plan to change them. > > I have another question, if net_lock in the board code is not properly adjusted, wouldn't this lead to deadlocks or race conditions? This is because after the modification, there will be 2 separate locks (one for the protocol stack and one for the board), and I am concerned that some callback strategies may result in ABBA dead lock @anchao Yes, If there is a callback strategy that may lead to ABBA deadlock, the corresponding driver will need to make relevant adaptations. Currently, we can only ensure that processes that net_lock is not first attempted to be acquired in the callback is compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
