yezhonghui2024 commented on PR #17719: URL: https://github.com/apache/nuttx/pull/17719#issuecomment-3708049422
> > > > > @yezhonghui2024 your Documentation is excellent! Really detailed, this is the kind of Documentation we need on NuttX. > > > > > Please also add later the host prepare steps you added here in the summary. > > > > > It could be inside a new sim:gpiochip board profile example Documentation/, so please submit the gpiochip board profile that you used for testing. This way someone willing to test it will just run: > > > > > ``` > > > > > $ ./tools/configure.sh sim:gpiochip > > > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > and follow the testing steps from Documentation. > > > > > > > > > > > > In test section， I add the host prepare steps already，it need a CH341A USB to SPI I2C Serial Adapter Module - Programmer/Converter and I support host drivers source. I don't see any meaningful advantages in introducing a sim:gpiochip board > > > > > > > > > I mean here: https://github.com/apache/nuttx/pull/17719/changes#diff-462098d5c4311e7d28a18bc110975ef12aa199ef7279ffa5e6d17dbad4d1433b > > > Remember: after the PR is merged and closed it will be difficult to end user find this PR with the test, this is why we need it in the Documentation. > > > > > > Documentation update: Add host setup prerequisites and external references to sim_gpiochip.rst @acassis > > @yezhonghui2024 I failed to find these steps in the Documentation: > > Testing > > prepare: > > ``` > need a ch341A usb module（CH341A USB to SPI I2C Serial Adapter Module - Programmer/Converter） > > host driver reference open source driver > [https://github.com/frank-zago/ch341-i2c-spi-gpio；make](https://github.com/frank-zago/ch341-i2c-spi-gpio%EF%BC%9Bmake) and install ko > sudo insmod ch341-core.ko > sudo insmod gpio-ch341.ko > sudo insmod i2c-ch341.ko > sudo insmod spi-ch341.ko > > ls /dev check /dev/gpiochipX exist > ``` > > 4.CONFIG_SIM_GPIOCHIP=y CONFIG_SIM_GPIOCHIP_NAME="/dev/gpiochipX" > > Maybe you forgot to push the Documentation modification, I noticed your last commit didn't modify any file inside Documentation/ Documentation/platforms/sim/sim_gpiochip.rst has follow information Host Prepare ============ Preparation required on the host side: - Hardware module required: USB-CH341A module - Refer to https://github.com/frank-zago/ch341-i2c-spi-gpio, and install the driver - Verify existence of /dev/gpiochipN device file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
