szafonimateusz-mi commented on code in PR #102: URL: https://github.com/apache/nuttx-testing/pull/102#discussion_r2660883320
########## arch/atomic/test_arch_atomic_integration.py: ########## @@ -0,0 +1,33 @@ +############################################################################ +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +import pytest + + [email protected]_config("CONFIG_TESTING_ATOMIC") [email protected]_check("atomic_main") Review Comment: yes, ELF binary is not supported now. `pytest.mark.cmd_check` is a remnant from the Xiaomi CI, but I think it should be removed in the future. Configuration checking (`pytest.mark.dep_config`) should be sufficient for test auto-detection. It won't be perfect, but it will work with ELF bin. In the worst case, the test case will report a failure due to "command not found", which can also help in detecting a certain class of bugs. Another approach is to dynamically scan whether a given directory contains ELF bin file, then we can leave `pytest.mark.cmd_check` and add this feature in NTFC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
