xiaoxiang781216 commented on code in PR #17781:
URL: https://github.com/apache/nuttx/pull/17781#discussion_r2666990070
##########
sched/hrtimer/hrtimer_cancel.c:
##########
@@ -208,5 +213,6 @@ int hrtimer_cancel_sync(FAR hrtimer_t *hrtimer)
}
}
+#endif
Review Comment:
move before line 215
##########
sched/hrtimer/hrtimer_cancel.c:
##########
@@ -199,7 +204,7 @@ int hrtimer_cancel_sync(FAR hrtimer_t *hrtimer)
* busy-waiting. Otherwise, spin until the callback completes
* and the state becomes inactive.
*/
-
+#ifdef CONFIG_SMP
while (hrtimer_is_active(hrtimer))
{
if (cansleep)
Review Comment:
let's remove cansleep and call up_interrupt_context and is_idle_task here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
