xiaoxiang781216 commented on code in PR #17826:
URL: https://github.com/apache/nuttx/pull/17826#discussion_r2680712092


##########
libs/libxx/libcxxabi/Make.defs:
##########
@@ -51,6 +53,9 @@ ifeq ($(CONFIG_LIBCXXABI), y)
 CXXFLAGS += ${DEFINE_PREFIX}LIBCXX_BUILDING_LIBCXXABI
 CXXFLAGS += -I $(TOPDIR)/libs/libxx/libcxxabi/libcxxabi/include
 
+# Define _LIBCPP_HAS_NO_THREADS for no-threading builds
+CXXFLAGS += ${DEFINE_PREFIX}_LIBCPP_HAS_NO_THREADS

Review Comment:
   but we need support thread before merging this pr



##########
arch/arm/src/cmake/gcc.cmake:
##########
@@ -274,6 +274,11 @@ if(NOT CONFIG_CXX_RTTI)
   add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-fno-rtti>)
 endif()
 
+# Add -mlong-calls for C++ when using libcxx to fix relocation issues
+if(CONFIG_LIBCXX)
+  add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-mlong-calls>)

Review Comment:
   do you hit this problem when generate elf binary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to