xuxin930 opened a new pull request, #17852:
URL: https://github.com/apache/nuttx/pull/17852
### Summary
This pull request introduces enhancements to the NuttX CMake build system to
improve visibility and debugging of CMake targets:
1. **Target Tracking** - Adds a new `nuttx_target_interface` target that
collects and maintains information about all CMake library targets created
during the build process.
2. **Public Include Path Inheritance** - Modifies the CMake library
configuration to use `PUBLIC` scope for include directories, enabling better
include path inheritance across the build dependency chain.
3. **Target Dump Utility** - Implements a `dump_targets` custom CMake target
that generates a target dump file for debugging and analysis purposes.
These changes provide developers with better insights into the CMake build
structure and facilitate troubleshooting of build system issues. The target
information collection mechanism can be leveraged for documentation generation,
build analysis tools, and improved build debugging.
---
### Impact
**Build System**
- Adds minimal overhead to the CMake build process through property tracking
- Introduces new `dump_targets` target that can be run independently
- Does not affect existing build output or binary artifacts
- Backward compatible with existing CMake configurations
**Developer Experience**
- Improved visibility into the CMake target structure
- Better debugging capabilities for complex build system issues
- Foundation for future build analysis and reporting features
**API Changes**
- None (internal CMake infrastructure change)
---
### Changes Made
#### File: nuttx_extensions.cmake
- Added `nuttx_target_interface` custom target to collect target information
- Added `dump_targets` custom target that:
- Removes any existing target_dump file
- Echoes target properties to console
- Appends target information to `target_dump` file in build directory
#### File: nuttx_add_library.cmake
- Modified `nuttx_add_library_internal()` function to:
- Track all created library targets in `nuttx_target_interface`
- Append target names to a targets file in the build directory
- Use `PUBLIC` scope for include directories to improve inheritance
---
### Testing
**Build System Verification**
1. Verified clean CMake build with new target tracking code
2. Confirmed no impact on existing library creation or configuration
3. Tested `dump_targets` custom target:
```bash
cmake --build . --target dump_targets
cat build/target_dump
```
4. Verified include path inheritance works correctly with PUBLIC scope
**Regression Testing**
- Full build completed successfully without errors
- All library targets created and linked correctly
- No compilation warnings introduced
- Existing configurations remain unaffected
**Platform Testing**
- Tested on Linux host system with NuttX simulator configuration
- CMake version compatibility verified (3.20+)
---
### Technical Details
The implementation leverages CMake's `APPEND` property mechanism to collect
target information across the entire build tree without invasive modifications
to existing code. The `$<TARGET_PROPERTY:...>` generator expression allows
dynamic evaluation of target properties at build time.
The PUBLIC include directory scope change aligns with CMake best practices
for library interface specifications and improves the build system's
composability for future enhancements.
---
### Notes for Reviewers
- The `dump_targets` feature is optional and does not impact normal builds
- Target dumping can be useful for automated build analysis and documentation
- Consider this as foundational infrastructure for future build system
improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
