Donny9 opened a new pull request, #17909: URL: https://github.com/apache/nuttx/pull/17909
## Summary This PR includes a series of fixes and improvements for the RPMSG RTC driver to enhance stability and functionality: 1. **Export RTC endpoint to remote CPU**: Refactor the RPMSG RTC driver to properly export the endpoint, allowing remote CPUs to access RTC services. This change simplifies the initialization flow and removes unnecessary Kconfig options. 2. **Prevent messages to cores without RTC client**: Add checks to avoid sending RPMSG messages to cores that don't have the RTC client driver installed, preventing communication errors. 3. **Fix list node crash**: Fix a critical crash that occurs when removing a client from the server list due to improper list initialization checks. 4. **Add null pointer check for ioctl**: Add proper null pointer validation for ioctl operations in the RTC driver to prevent crashes when ioctl function pointer is NULL, returning -ENOTTY as appropriate. These changes improve the robustness and reliability of the RPMSG RTC driver in multi-core systems. ## Impact - **Stability**: Fixes critical crashes related to list operations and null pointer dereferences - **Compatibility**: Improves multi-core communication by preventing invalid message sends - **Code Quality**: Simplifies the driver initialization flow and removes unnecessary configuration options - **No breaking changes**: All changes are backward compatible ## Testing **Test Environment:** - Host: Linux x## Summary This PR includes a series of fixes and improvements for the RPMSG RTC driver to enhance stability and functionality: 1. **Export RTC endpoint to remote CPU**: Refactor the RPMSG RTC driver to properly export the endpoint, allowing remote CPUs to access RTC services. This change simplifies the initialization flow and removes unnecessary Kconfig options. 2. **Prevent messages to cores without RTC client**: Add checks to avoid sending RPMSG messages to cores that don't have the RTC client driver installed, preventing communication errors. 3. **Fix list node crash**: Fix a critical crash that occurs when removing a client from the server list due to improper list initialization checks. 4. **Add null pointer check for ioctl**: Add proper null pointer validation for ioctl operations in the RTC driver to prevent crashes when ioctl function pointer is NULL, returning -ENOTTY as appropriate. These changes improve the robustness and reliability of the RPMSG RTC driver in multi-core systems. ## Impact - **Stability**: Fixes critical crashes related to list operations and null pointer dereferences - **Compatibility**: Improves multi-core communication by preventing invalid message sends - **Code Quality**: Simplifies the driver initialization flow and removes unnecessary configuration options - **No breaking changes**: All changes are backward compatible ## Testing **Test Environment:** - Host: Linux x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
