Barto22 commented on PR #17849:
URL: https://github.com/apache/nuttx/pull/17849#issuecomment-3750157266

   > @Barto22 Why is it necessary to completely update the Dockerfile?
   > 
   > 
   > 
   > Wouldn't it be preferable to update it step by step?
   > 
   > 
   > 
   > I quickly tested only job arm-01 and found these errors.
   > 
   > 
   > 
   > ```
   > 
   > 
====================================================================================
   > 
   > Configuration/Tool: spresense/camera,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   > 2026-01-14 11:17:43
   > 
   > 
------------------------------------------------------------------------------------
   > 
   >   Cleaning...
   > 
   >   Configuring...
   > 
   >   Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Building NuttX...
   > 
   > In file included from 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/include/nuttx/video/v4l2_cap.h:29,
   > 
   >                  from video/v4l2_cap.c:35:
   > 
   > video/v4l2_cap.c: In function 'start_capture':
   > 
   > video/v4l2_cap.c:802:3: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >   802 |   IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |   ^~~~~~~~~~~~~~~
   > 
   > video/v4l2_cap.c: In function 'complete_capture':
   > 
   > video/v4l2_cap.c:2035:11: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >  2035 |           IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |           ^~~~~~~~~~~~~~~
   > 
   > make[1]: *** [Makefile:109: v4l2_cap.o] Error 1
   > 
   > video/isx019.c: In function 'set_spot_position':
   > 
   > video/isx019.c:2621:6: error: 'w' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  2621 |   if ((x >= w) || (y >= h))
   > 
   >       |      ^
   > 
   > video/isx019.c:2599:12: note: 'w' was declared here
   > 
   >  2599 |   uint16_t w;
   > 
   >       |            ^
   > 
   > video/isx019.c:2621:16: error: 'h' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  2621 |   if ((x >= w) || (y >= h))
   > 
   >       |       ~~~~~~~~~^~~~~~~~~~~
   > 
   > video/isx019.c:2600:12: note: 'h' was declared here
   > 
   >  2600 |   uint16_t h;
   > 
   >       |            ^
   > 
   > In function 'restore_spot_position',
   > 
   >     inlined from 'get_spot_position' at video/isx019.c:3343:7:
   > 
   > video/isx019.c:3293:13: error: 'w' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  3293 |   ret = ret * sz / basis;
   > 
   >       |         ~~~~^~~~
   > 
   > video/isx019.c: In function 'get_spot_position':
   > 
   > video/isx019.c:3325:12: note: 'w' was declared here
   > 
   >  3325 |   uint16_t w;
   > 
   >       |            ^
   > 
   > In function 'restore_spot_position',
   > 
   >     inlined from 'get_spot_position' at video/isx019.c:3345:7:
   > 
   > video/isx019.c:3293:13: error: 'h' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  3293 |   ret = ret * sz / basis;
   > 
   >       |         ~~~~^~~~
   > 
   > video/isx019.c: In function 'get_spot_position':
   > 
   > video/isx019.c:3326:12: note: 'h' was declared here
   > 
   >  3326 |   uint16_t h;
   > 
   >       |            ^
   > 
   > cc1: all warnings being treated as errors
   > 
   > make[1]: *** [Makefile:109: isx019.o] Error 1
   > 
   > make[1]: Target 'libdrivers.a' not remade because of errors.
   > 
   > make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
   > 
   > make: Target 'all' not remade because of errors.
   > 
   > /__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/tools/testbuild.sh: line 385: 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/../nuttx/nuttx.manifest: No such 
file or directory
   > 
   >   [1/1] Normalize spresense/camera
   > 
   > 
   > 
   > 
====================================================================================
   > 
   > Configuration/Tool: spresense/example_camera,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   > 2026-01-14 11:21:53
   > 
   > 
------------------------------------------------------------------------------------
   > 
   >   Cleaning...
   > 
   >   Configuring...
   > 
   >   Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Building NuttX...
   > 
   > In file included from 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/include/nuttx/video/v4l2_cap.h:29,
   > 
   >                  from video/v4l2_cap.c:35:
   > 
   > video/v4l2_cap.c: In function 'start_capture':
   > 
   > video/v4l2_cap.c:802:3: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >   802 |   IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |   ^~~~~~~~~~~~~~~
   > 
   > video/v4l2_cap.c: In function 'complete_capture':
   > 
   > video/v4l2_cap.c:2035:11: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >  2035 |           IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |           ^~~~~~~~~~~~~~~
   > 
   > make[1]: *** [Makefile:109: v4l2_cap.o] Error 1
   > 
   > video/isx019.c: In function 'set_spot_position':
   > 
   > video/isx019.c:2621:6: error: 'w' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  2621 |   if ((x >= w) || (y >= h))
   > 
   >       |      ^
   > 
   > video/isx019.c:2599:12: note: 'w' was declared here
   > 
   >  2599 |   uint16_t w;
   > 
   >       |            ^
   > 
   > video/isx019.c:2621:16: error: 'h' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  2621 |   if ((x >= w) || (y >= h))
   > 
   >       |       ~~~~~~~~~^~~~~~~~~~~
   > 
   > video/isx019.c:2600:12: note: 'h' was declared here
   > 
   >  2600 |   uint16_t h;
   > 
   >       |            ^
   > 
   > In function 'restore_spot_position',
   > 
   >     inlined from 'get_spot_position' at video/isx019.c:3343:7:
   > 
   > video/isx019.c:3293:13: error: 'w' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  3293 |   ret = ret * sz / basis;
   > 
   >       |         ~~~~^~~~
   > 
   > video/isx019.c: In function 'get_spot_position':
   > 
   > video/isx019.c:3325:12: note: 'w' was declared here
   > 
   >  3325 |   uint16_t w;
   > 
   >       |            ^
   > 
   > In function 'restore_spot_position',
   > 
   >     inlined from 'get_spot_position' at video/isx019.c:3345:7:
   > 
   > video/isx019.c:3293:13: error: 'h' may be used uninitialized 
[-Werror=maybe-uninitialized]
   > 
   >  3293 |   ret = ret * sz / basis;
   > 
   >       |         ~~~~^~~~
   > 
   > video/isx019.c: In function 'get_spot_position':
   > 
   > video/isx019.c:3326:12: note: 'h' was declared here
   > 
   >  3326 |   uint16_t h;
   > 
   >       |            ^
   > 
   > cc1: all warnings being treated as errors
   > 
   > make[1]: *** [Makefile:109: isx019.o] Error 1
   > 
   > make[1]: Target 'libdrivers.a' not remade because of errors.
   > 
   > make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
   > 
   > make: Target 'all' not remade because of errors.
   > 
   > /__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/tools/testbuild.sh: line 385: 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/../nuttx/nuttx.manifest: No such 
file or directory
   > 
   >   [1/1] Normalize spresense/example_camera
   > 
   > 
====================================================================================
   > 
   > Configuration/Tool: spresense/mpy,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   > 2026-01-14 11:22:37
   > 
   > 
------------------------------------------------------------------------------------
   > 
   >   Cleaning...
   > 
   >   Configuring...
   > 
   >   Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > 
   >   Building NuttX...
   > 
   > In file included from 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/include/nuttx/video/v4l2_cap.h:29,
   > 
   >                  from video/v4l2_cap.c:35:
   > 
   > video/v4l2_cap.c: In function 'start_capture':
   > 
   > video/v4l2_cap.c:802:3: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >   802 |   IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |   ^~~~~~~~~~~~~~~
   > 
   > video/v4l2_cap.c: In function 'complete_capture':
   > 
   > video/v4l2_cap.c:2035:11: error: pointer/integer type mismatch in 
conditional expression [-Wint-conversion]
   > 
   >  2035 |           IMGDATA_SET_BUF(cmng->imgdata,
   > 
   >       |           ^~~~~~~~~~~~~~~
   > 
   > make[1]: *** [Makefile:109: v4l2_cap.o] Error 1
   > 
   > make[1]: Target 'libdrivers.a' not remade because of errors.
   > 
   > make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
   > 
   > make: Target 'all' not remade because of errors.
   > 
   > /__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/tools/testbuild.sh: line 385: 
/__w/nuttx-bump/nuttx-bump/nuttxspace/nuttx/../nuttx/nuttx.manifest: No such 
file or directory
   > 
   >   [1/1] Normalize spresense/mpy
   > 
   > 
====================================================================================
   > 
   > ```
   
   I will check that errors, I see that this are mostly some int conversion 
errors, I will check that. Thanks for pointing out. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to