michallenc commented on code in PR #17882: URL: https://github.com/apache/nuttx/pull/17882#discussion_r2694304197
########## include/fnmatch.h: ########## @@ -37,6 +37,7 @@ #define FNM_PATHNAME 0x01 #define FNM_PERIOD 0x02 #define FNM_NOESCAPE 0x04 +#define FNM_CASEFOLD 0x10 Review Comment: Looking at `fnmatch` source code (`libs/libc/misc/lib_fnmatch.c`) it doesn't seem to reflect flags at all. Yes, they are passed as an argument, but completely ignored in the matching process (in a violation with what the documentation states). Just noting, not sure if it's gonna cause you some troubles with the archivefs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
