[incubator-nuttx] branch master updated: drivers: wireless: Refactor gs2200m.c

[jerpelea]

This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 07b4b21  drivers: wireless: Refactor gs2200m.c
07b4b21 is described below

commit 07b4b219cd7731f97ff36bcae61c3817ea326351
Author: Masayuki Ishikawa <masayuki.ishik...@gmail.com>
AuthorDate: Tue Aug 25 16:07:12 2020 +0900

    drivers: wireless: Refactor gs2200m.c
    
    Summary:
    - Remove unnecessay code from gs2200m_irq()
    - Fix irq control in case that work_available() returns false
    
    Impact:
    - All use cases with gs2200m driver
    
    Testing:
    - Tested with spresense:wifi
    
    Signed-off-by: Masayuki Ishikawa <masayuki.ishik...@jp.sony.com>
---
 drivers/wireless/gs2200m.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/wireless/gs2200m.c b/drivers/wireless/gs2200m.c
index 2d526c6..fe61d68 100644
--- a/drivers/wireless/gs2200m.c
+++ b/drivers/wireless/gs2200m.c
@@ -3086,26 +3086,22 @@ errout:
 static int gs2200m_irq(int irq, FAR void *context, FAR void *arg)
 {
   FAR struct gs2200m_dev_s *dev;
-  int ec = 0;
 
   DEBUGASSERT(arg != NULL);
   dev = (FAR struct gs2200m_dev_s *)arg;
 
-  dev->lower->dready(&ec);
-  ASSERT(0 < ec);
-
   wlinfo(">>>> \n");
 
-  /* NOTE: Disable gs2200m irq during processing */
-
-  dev->lower->disable();
-
   if (!work_available(&dev->irq_work))
     {
       wlwarn("*** warning: there is still pending work **** \n");
       return 0;
     }
 
+  /* NOTE: Disable gs2200m irq during processing */
+
+  dev->lower->disable();
+
   return work_queue(GS2200MWORK, &dev->irq_work, gs2200m_irq_worker,
                     (FAR void *)dev, 0);
 }