cederom commented on code in PR #3315:
URL: https://github.com/apache/nuttx-apps/pull/3315#discussion_r2699201507
##########
netutils/netinit/netinit.c:
##########
@@ -286,7 +286,10 @@ static const uint16_t g_ipv6_netmask[8] =
defined(HAVE_MAC)
static void netinit_set_macaddr(void)
{
-#if defined(CONFIG_NETINIT_UIDMAC)
+#if defined(CONFIG_NETINIT_WIFIMAC)
Review Comment:
What if both wifi and eth are available? Having wifi defined will discard
mac definition, correct?
Shouldn't we
```
#if defined(CONFIG_NETINIT_WIFIMAC)
char wifi_mac_str[20];
uint8_t wifi_mac[IFHWADDRLEN];
#endif
#if defined(CONFIG_NETINIT_UIDMAC)
..
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
