xiaoxiang781216 commented on code in PR #17991:
URL: https://github.com/apache/nuttx/pull/17991#discussion_r2703242765
##########
drivers/wireless/ieee802154/xbee/xbee_netdev.c:
##########
@@ -410,12 +410,14 @@ static int xbeenet_notify(FAR struct xbee_maccb_s *maccb,
nxsem_post(&priv->xd_eventsem);
}
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
if (priv->xd_notify_registered)
{
priv->xd_notify_event.sigev_value.sival_int = primitive->type;
Review Comment:
guard in xbeenet_driver_s too
##########
drivers/lcd/ft80x.c:
##########
@@ -271,6 +276,7 @@ static void ft80x_notify(FAR struct ft80x_dev_s *priv,
info->event.sigev_value.sival_int = value;
Review Comment:
need guard event in ft80x_dev_s
##########
drivers/input/djoystick.c:
##########
@@ -271,6 +271,7 @@ static void djoy_sample(FAR struct djoy_upperhalf_s *priv)
/* Have any signal events occurred? */
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
if ((press & opriv->do_notify.dn_press) != 0 ||
Review Comment:
need remove from djoy_open_s
##########
drivers/input/button_upper.c:
##########
@@ -297,6 +297,7 @@ static void btn_sample(wdparm_t arg)
/* Have any signal events occurred? */
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
if ((press & opriv->bo_notify.bn_press) != 0 ||
Review Comment:
nee d remove from btn_open_s
##########
wireless/ieee802154/mac802154_netdev.c:
##########
@@ -378,12 +378,14 @@ static int macnet_notify(FAR struct mac802154_maccb_s
*maccb,
nxsem_post(&priv->md_eventsem);
}
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
if (priv->md_notify_registered)
{
priv->md_notify_event.sigev_value.sival_int = primitive->type;
Review Comment:
guard md_notify_event in mac802154_chardevice_s
##########
libs/libc/aio/lio_listio.c:
##########
@@ -210,6 +210,11 @@ static void lio_sighandler(int signo, siginfo_t *info,
void *ucontext)
static int lio_sigsetup(FAR struct aiocb * const *list, int nent,
Review Comment:
does aio still work without signal? if not, we should diasable all aio
functionality.
##########
fs/mount/fs_automount.c:
##########
Review Comment:
does automount functionality still work
##########
libs/libc/aio/lio_listio.c:
##########
Review Comment:
guard in aiocb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
