txy-21 opened a new pull request, #3357: URL: https://github.com/apache/nuttx-apps/pull/3357
## Summary This PR fixes multiple compilation issues across various apps modules by adding missing header files. The changes ensure proper compilation with different build systems and toolchains. ## Changes This PR includes 7 commits addressing different compilation issues: 1. **system/popen**: Fix file descriptor leak when newfd[0] equals newfd[1] 2. **testing/testsuites**: Add malloc.h for fstest.h 3. **netutils/system**: Add missing headers in codecs, ftpd, and lsan 4. **testing**: Add unistd.h and pthread.h to various test modules 5. **testing/drivers**: Add unistd.h for touchpanel driver test 6. **netutils/rexec**: Fix Android.bp build configuration 7. **netutils/rexecd**: Fix pointer-to-integer cast warning ### Files Modified - `system/popen/popen.c` - Fixed file descriptor handling - `testing/testsuites/kernel/fs/include/fstest.h` - Added malloc.h - `netutils/codecs/md5.c` - Added missing header - `netutils/ftpd/ftpd.c` - Added missing header - `system/lsan/lsan_main.c` - Added missing header - `testing/mm/memstress/memorystress_main.c` - Added unistd.h and pthread.h - `testing/drivers/crypto/dhm.c` - Added unistd.h - `testing/mm/cachetest/cachetest_main.c` - Added unistd.h - `testing/drivers/drivertest/drivertest_touchpanel.c` - Added unistd.h - `netutils/rexec/Android.bp` - Created Android build file - `netutils/rexecd/Android.bp` - Created Android build file - `netutils/rexec/rexec.c` - Added missing headers - `netutils/rexecd/rexecd.c` - Fixed type cast issue ## Impact - **Stability**: Fixes compilation issues that could prevent building on certain platforms - **Compatibility**: Ensures proper header inclusion for POSIX compliance - **Code Quality**: Eliminates compiler warnings and potential runtime issues - **Breaking Changes**: None - these are build fixes only ## Testing ### Test Environment - **Host**: Linux x86_64 - **Toolchain**: GCC 11.4.0 - **Build**: Multiple configurations tested ### Test Steps 1. Built affected modules with Android.bp method 2. Verified no compilation errors or warnings 3. Ran existing unit tests for affected modules 4. Confirmed no functional regressions ### Test Results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
