acassis commented on code in PR #18044:
URL: https://github.com/apache/nuttx/pull/18044#discussion_r2712196326
##########
drivers/rpmsg/Kconfig:
##########
@@ -130,6 +130,23 @@ config RPMSG_VIRTIO_STACKSIZE
int "rpmsg virtio stack size"
default DEFAULT_TASK_STACKSIZE
+config RPMSG_VIRTIO_PM
+ bool "rpmsg virtio power management"
+ depends on PM
+ default n
+ ---help---
+ If TX/RX buffer is supplied and powered by each CPU.
+ And when one CPU in DEEP sleep, then it's buffer will
+ goto RAM-retention mode, can't access from another CPU.
+ So, we provide this method to resolve this.
+
+config RPMSG_VIRTIO_PM_AUTORELAX
+ bool "rpmsg virtio pm autorelax"
+ depends on RPMSG_VIRTIO_PM
+ default y
+ ---help---
+ use wd_timer to auto relax pm
Review Comment:
Please include an informative help, explaining the real purpose in simple
words. What is auto relax PM? When and why to use it?
##########
drivers/rpmsg/Kconfig:
##########
@@ -130,6 +130,23 @@ config RPMSG_VIRTIO_STACKSIZE
int "rpmsg virtio stack size"
default DEFAULT_TASK_STACKSIZE
+config RPMSG_VIRTIO_PM
+ bool "rpmsg virtio power management"
Review Comment:
```suggestion
bool "RPMsg VirtIO power management"
##########
drivers/rpmsg/Kconfig:
##########
@@ -130,6 +130,23 @@ config RPMSG_VIRTIO_STACKSIZE
int "rpmsg virtio stack size"
default DEFAULT_TASK_STACKSIZE
+config RPMSG_VIRTIO_PM
+ bool "rpmsg virtio power management"
Review Comment:
Please see
https://openamp.readthedocs.io/en/latest/protocol_details/rpmsg.html let's use
the proper text case
##########
drivers/rpmsg/Kconfig:
##########
@@ -130,6 +130,23 @@ config RPMSG_VIRTIO_STACKSIZE
int "rpmsg virtio stack size"
default DEFAULT_TASK_STACKSIZE
+config RPMSG_VIRTIO_PM
+ bool "rpmsg virtio power management"
+ depends on PM
+ default n
+ ---help---
+ If TX/RX buffer is supplied and powered by each CPU.
+ And when one CPU in DEEP sleep, then it's buffer will
+ goto RAM-retention mode, can't access from another CPU.
+ So, we provide this method to resolve this.
+
+config RPMSG_VIRTIO_PM_AUTORELAX
+ bool "rpmsg virtio pm autorelax"
Review Comment:
``suggestion
bool "RPMsg VirtIO PM autorelax"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
