jerpelea commented on code in PR #18090:
URL: https://github.com/apache/nuttx/pull/18090#discussion_r2716551674
##########
sched/irq/irq_chain.c:
##########
@@ -128,26 +128,31 @@ void irqchain_initialize(void)
bool is_irqchain(int ndx, xcpt_t isr)
{
+ bool ret;
+
if (g_irqvector[ndx].handler == irq_unexpected_isr ||
g_irqvector[ndx].handler == NULL)
{
- return false;
+ ret = false;
}
else if (g_irqvector[ndx].handler == irqchain_dispatch)
{
- return true;
+ ret = true;
}
else
{
- return isr != irq_unexpected_isr;
+ ret = isr != irq_unexpected_isr;
}
+
+ return ret;
}
int irqchain_attach(int ndx, xcpt_t isr, FAR void *arg)
{
FAR struct irqchain_s *node;
FAR struct irqchain_s *curr;
irqstate_t flags;
+ int ret = OK;
Review Comment:
to avoid confusion please initialize with 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]