cederom commented on code in PR #3374: URL: https://github.com/apache/nuttx-apps/pull/3374#discussion_r2721164391
########## testing/testsuites/kernel/fs/cases/fs_dup_test.c: ########## @@ -60,15 +60,11 @@ void test_nuttx_fs_dup01(FAR void **state) char buffd[5] = "hello"; char bufnewfd[8] = "littleFS"; char readbuf[20] = ""; - struct fs_testsuites_state_s *test_state; Review Comment: Thank you @victor-suisui in the git commit message some short explanation for anyone reading the git log why this is removed would be welcome.. what it fixes, updates, maybe it was unused, is it safe to remove? :-) Description from the PR is perfect: > Removes unnecessary test_state structure usage for tracking file descriptors Adds missing close(newfd) call in fs_dup_test.c to prevent file descriptor leaks Simplifies test code by eliminating redundant fd tracking that could lead to incorrect resource management -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
